Conversation
… Added class variable in stores/protocol to allow specifying error responses related directly to loading/unloading the Hkl object store
…nclude pep8-naming
…n types from services
…ll under a collection, eg several samples may relate to one beamline for example
callumforrester
left a comment
callumforrester
left a comment
There was a problem hiding this comment.
Looks good, a few minor tweaks and possibly some splitting needed, see comments.
Also, doesn't currently work out-of-box as you need to manually install the master branch of diffcalc-core. Do we know if a release is likely in the near future?
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=========================================
Coverage ? 86.31%
=========================================
Files ? 25
Lines ? 519
Branches ? 0
=========================================
Hits ? 448
Misses ? 71
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
Just a comment - diffcalc-core has now been released with my changes so I no longer need to pull from the branch manually. I'll update this now. Edit: my changes have been merged into master but a new version on pypi hasn't been released yet. So, not sure - am speaking with Irakli about this now. |
…ore creation. Seperate PR to follow to take all side effects out
4 participants
No description provided.